Skip to content

zend: fix missing return in global register detection (phpGH-22206) - #22319

Closed
P3p111n0 wants to merge 5286 commits into
php:PHP-8.4from
P3p111n0:master
Closed

P3p111n0 wants to merge 5286 commits into
php:PHP-8.4from
P3p111n0:master

Conversation

@P3p111n0

Copy link
Copy Markdown
Contributor

Hi,
this pull request add a missing return statement to zend global registers detection, fixing a build failure with -Werror=return-type with GCC 16.

When building with -Werror=return-type, the global registers detection ends with an error, even though global registers are supported. The preserve_none attribute is newly supported, which along with "unsupported" global registers leads to ZEND_VM_KIND being set to ZEND_VM_KIND_TAILCALL, which later produces the error described in the linked issue. This pull request fixes that.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.