Repository navigation
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this pull request add a missing return statement to zend global registers detection, fixing a build failure with
-Werror=return-typewith GCC 16.When building with
-Werror=return-type, the global registers detection ends with an error, even though global registers are supported. Thepreserve_noneattribute is newly supported, which along with "unsupported" global registers leads toZEND_VM_KINDbeing set toZEND_VM_KIND_TAILCALL, which later produces the error described in the linked issue. This pull request fixes that.